New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscroll after folding from keyboard, take 2 #16186

Merged
merged 2 commits into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@nathansobo
Contributor

nathansobo commented Nov 14, 2017

This PR reverts a previous attempt in #16092 which was a bit too aggressive. It auto-scrolled at the model level after various folds. This PR tries a more conservative approach that simply auto-scrolls after fold commands. Auto-scrolling seems most intuitive when executed from the keyboard via a command.

Thanks @maxbrunsfeld for the early feedback. 馃挴

nathansobo added some commits Nov 14, 2017

Revert "Merge pull request #16092 from atom/autoscroll-after-fold-or-鈥
鈥nfold"

This reverts commit 6227ece, reversing
changes made to 311055c.
Auto-scroll after folding/unfolding via a command
In my previous attempt in #16092, I was autoscrolling in the TextEditor
methods themselves. But this could lead to undesirable autoscrolling
when folding with the mouse.
@maxbrunsfeld

鈿★笍

@nathansobo nathansobo merged commit 4250954 into master Nov 15, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the ns-autoscroll-after-folding-from-keyboard branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment