New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTTP Links to HTTPS in /docs/build-instructions/ #16197

Merged
merged 3 commits into from Nov 15, 2017

Conversation

Projects
None yet
3 participants
@U8NWXD
Contributor

U8NWXD commented Nov 15, 2017

Description of the Change

Change HTTP links to HTTPS in /docs/build-instructions/ since the linked-to sites support SSL/TLS

Alternate Designs

The alternative would be leaving the links as HTTP ones. This leaves users less secure while having only marginal userexperience benefits.

Why Should This Be In Core?

The documentation changed is in Core.

Benefits

Makes user interaction more secure by default.

Possible Drawbacks

Marginal potential for devices not supporting SSL/TLS and marginal performance hits when accessing the links.

Applicable Issues

Similar to issue #16167 and PR #16173

U8NWXD added some commits Nov 15, 2017

Change HTTP Links to HTTPS in linux.md
Similar to issue #16167 and PR #16173 Change links throughout docs/build-instructions/linux.md to support SSL/TLS by changing URL to `https://`
[ci skip]

Signed-off-by: U8N WXD <cs.temporary@icloud.com>
Change HTTP Links to HTTPS in macOS.md
Similar to issue #16167 and PR #16173 Change links throughout docs/build-instructions/macOS.md to support SSL/TLS by changing URL to `https://`
[ci skip]

Signed-off-by: U8N WXD <cs.temporary@icloud.com>
Change HTTP Links to HTTPS in windows.md
Similar to issue #16167 and PR #16173 Change links throughout docs/build-instructions/windows.md to support SSL/TLS by changing URL to `https://`
[ci skip]

Signed-off-by: U8N WXD <cs.temporary@icloud.com>
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 15, 2017

Member

Great work as usual @U8NWXD.

Member

50Wliu commented Nov 15, 2017

Great work as usual @U8NWXD.

@50Wliu 50Wliu merged commit 85e7bca into atom:master Nov 15, 2017

@U8NWXD U8NWXD deleted the U8NWXD:fix-non-ssl-in-building branch Nov 17, 2017

@mehedicse1

This comment was marked as spam.

Show comment
Hide comment
@mehedicse1

mehedicse1 Sep 21, 2018

sir , how to work it ?

mehedicse1 commented on 98121f3 Sep 21, 2018

sir , how to work it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment