New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native Array.isArray in application-delegate #16227

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 17, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Uses the native Array.isArray function in application-delegate, because that's what underscore-plus does anyway.

Alternate Designs

None.

Why Should This Be In Core?

Code cleanup.

Benefits

馃帹

Possible Drawbacks

None.

Applicable Issues

None.

@50Wliu 50Wliu merged commit 6576d26 into master Nov 17, 2017

0 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@50Wliu 50Wliu deleted the wl-rm-application-delegate-underscore-plus branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment