Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make atom.confirm async #16229
Description of the Change
This change is a bit more involved than making ContextMenu async.
The callbackiness is quite messy, especially when we used to return something based on the response value. Anywhere where that occurred I had to pseudo-promisify the dialog and then await the resulting promise. Would it therefore make more sense to directly promisify the async version of
Why Should This Be In Core?
Unlike making the context menu async, this is an opt-in change. Package authors will have to update their code to support the async message dialog. As such, there is a possibility that people will create issues on atom/atom asking why certain message boxes are async while others aren't. Furthermore, as discussed above, using the callback is much less clean than simply blocking and waiting for a return value.