New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make issues links work even when not logged in #16230

Merged
merged 2 commits into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@U8NWXD
Contributor

U8NWXD commented Nov 18, 2017

Description of the Change

Update links in CONTRIBUTING.md to issue searches which work when not logged in to GitHub.

Alternate Designs

The alternative would be to leave the links as they are, which could hinder user interaction.

Why Should This Be In Core?

The affected documentation is in Core.

Benefits

The links will now work for users who are not logged in to GitHub.

Possible Drawbacks

None.

Applicable Issues

None.

U8NWXD added some commits Nov 18, 2017

Repair Links to Issues in CONTRIBUTING.md
Repair broken links in CONTRIBUTING.md that point to GitHub issue searches
[ci skip]

Signed-off-by: U8N WXD <cs.temporary@icloud.com>
Repair Links to Pull Requests in CONTRIBUTING.md
Repair broken links in CONTRIBUTING.md that point to GitHub pull request searches
[ci skip]

Signed-off-by: U8N WXD <cs.temporary@icloud.com>
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 18, 2017

Member

Hmm, both /search and /issues work for me: is that not what you're seeing?

Member

50Wliu commented Nov 18, 2017

Hmm, both /search and /issues work for me: is that not what you're seeing?

@U8NWXD

This comment has been minimized.

Show comment
Hide comment
@U8NWXD

U8NWXD Nov 18, 2017

Contributor

Maybe it is dependent on whether you are signed into GitHub? Normally when I try to open https://github.com/issues?q=+is%3Aissue+user%3Aatom I get a 404 error page from GitHub, but when I try while logged in, it works. When I am logged in, both /search and /issues work, though the pages are designed differently.

Contributor

U8NWXD commented Nov 18, 2017

Maybe it is dependent on whether you are signed into GitHub? Normally when I try to open https://github.com/issues?q=+is%3Aissue+user%3Aatom I get a 404 error page from GitHub, but when I try while logged in, it works. When I am logged in, both /search and /issues work, though the pages are designed differently.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 18, 2017

Member

Ah. @lee-dohm I believe you're more familiar with this.

Member

50Wliu commented Nov 18, 2017

Ah. @lee-dohm I believe you're more familiar with this.

@lee-dohm lee-dohm changed the title from Repair Links in CONTRIBUTING.md to Make issues links work even when not logged in Nov 20, 2017

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Nov 20, 2017

Member

I updated the title and description to make it more clear what the problem and goals were. Thanks for the contribution!

Member

lee-dohm commented Nov 20, 2017

I updated the title and description to make it more clear what the problem and goals were. Thanks for the contribution!

@lee-dohm lee-dohm merged commit 03cb00c into atom:master Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment