New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spec stack traces #16256

Merged
merged 3 commits into from Dec 4, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 21, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Two enhancements and one bugfix.

  • Formats at it (path.js:1:2) to simply at path.js:1:2
  • Speeds up line parsing by updating firstJasmineLinePattern to match when the line starts with at jasmine. and ends with a Jasmine filepath
  • Only replaces forward slashes with backslashes on Windows when file:/// is present on the same line

Also changed the for...of loop to lines.map.

Alternate Designs

None.

Why Should This Be In Core?

Unfortunately, this is in core and not a separate module :/.

Benefits

Better stacktrace reporting

Possible Drawbacks

If the stacktrace line starts with anything we're trying to replace it will get replaced. In addition, there is a possibility that stacktraces are reported differently on macOS and Linux. I doubt that however.

Applicable Issues

Fixes #14053, a regression caused by my previous stacktrace formatting PR.

50Wliu added some commits Nov 21, 2017

@50Wliu 50Wliu merged commit 4ac6b72 into master Dec 4, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-more-reporter-work branch Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment