New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all opened editors' buffers are added to the project #16306

merged 2 commits into from Dec 1, 2017


None yet
1 participant

maxbrunsfeld commented Dec 1, 2017

This fixes a regression introduced in #16087 where if you created and opened an editor like this:

const buffer = new TextBuffer()
const editor = new TextEditor({buffer})

the editor's buffer would never have a language mode assigned to it.

/cc @as-cii - 馃帺 for finding this bug

maxbrunsfeld added some commits Dec 1, 2017

Ensure that all opened editors' buffers are added to the project
Assigning a language mode happens when adding a buffer to the project,
so we need to guarantee this happens to all buffers used by visible editors.

@maxbrunsfeld maxbrunsfeld merged commit b930ad1 into master Dec 1, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@maxbrunsfeld maxbrunsfeld deleted the mb-ensure-buffers-have-language-modes branch Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment