New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buildIndentString method instead of hard-coding spaces #16319

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@leroix
Contributor

leroix commented Dec 4, 2017

fix #16193

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Dec 4, 2017

Contributor

⚡️ Thanks for fixing this!

Contributor

maxbrunsfeld commented Dec 4, 2017

⚡️ Thanks for fixing this!

@leroix leroix merged commit 4f73e81 into master Dec 4, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@leroix leroix deleted the fix-tabs-converted-to-spaces branch Dec 4, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Dec 4, 2017

Member

@leroix should some specs be added to this to make sure it doesn't regress again in the future?

Member

50Wliu commented Dec 4, 2017

@leroix should some specs be added to this to make sure it doesn't regress again in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment