Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'cmd--': As default for 'window:decrease-font-size' on MacOs #16342

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@davidrsfalcao
Copy link
Contributor

davidrsfalcao commented Dec 7, 2017

Description of the Change

The keybinding 'cmd--' appears instead of 'cmd-_' on 'View' drop down


captura de ecra 2017-12-07 as 19 06 29

Alternate Designs

none.

Why Should This Be In Core?

Fix issue #16024

Benefits

'cmd--' is more used and more pratical too.

Possible Drawbacks

none

Applicable Issues

#16024

@Aerijo

This comment has been minimized.

Copy link
Member

Aerijo commented Jul 25, 2018

Nice. This technically makes it inconsistent (regarding pressing shift or not) with the displayed =/+ shortcut, but seeing as both _ and - do the same thing it shouldn't be a problem.

More to the point, who designed the keyboard to have -= and _+ be pairs, but not -+? 😄

@Aerijo Aerijo merged commit 1fc0f0d into atom:master Jul 25, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.