This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Ensure that new editors get unique ids #16455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the behavior from when
TextEditor
was written in Coffeescript and extended theModel
class.Description of the Change
With this change, editors opened after restoring the window state will get assigned IDs starting from
max(editor IDs) + 1
.Alternate Designs
An alternative could be to select the lowest available unique ID. This would require a more complicated ID generator, but is certainly possible if a more dense ID space is desirable.
Why Should This Be In Core?
Assuming that editor IDs are supposed to be unique, this is a bug in core.
Benefits
Packages that look up editor instances by ID will be able to resolve to the correct editor.
Possible Drawbacks
I'm not aware of any drawbacks.
Applicable Issues
Fixes #16454.