Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Restore selectionsMarkerLayer of different editor #16564
Description of the Change
Scenario this PR intends
Before This PR
Undo/redo restore selection(= cursor) snapshotted on that editor.
After this PR
Undo/redo restore selection(= cursor) snapshotted on change initiated editor.
I don't know
Why Should This Be In Core?
Since we cannot fix this on user side(init script/packages).
User can see textual change when undo/redo where multiple editors which shares same buffer instance were opened.
Add some complexity, adding text-editor specific code onto text-buffer's core.
Scenario Which I want to fix(or improve)
Open multiple text-editors which shares same buffer
NOTE: Require changes' in atom's text-editor to use new machanism
I'm a bit confused by this comment, since I thought you understand background and said "make sense" in atom/text-buffer#287 (comment)
And I need this feature in practice.
I've merged atom/text-buffer#287, released it in firstname.lastname@example.org, and added it to atom in cdab85d, so if you merge master you should be able to use marker roles. Go ahead and ping me when you've got it in a good state and I'll help you get it merged