Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add `configurable: true` to browserwindow.loadSettingsJSON #16701
Description of the Change
Some packages, including Facebook's Nuclide, rely on monkey-patching browserWindow.loadSettingsJSON. Recent changes to the master branch of atom (the addition of the ConfigFile class / related code) changed the behavior of this property, adding a getter using Object.defineProperty.
Ideally we would like to fix the regression with only changes to Nuclide, but we could not find another way to monkeypatch browserWindow.loadSettingsJSON, without adding
Why Should This Be In Core?
To fix a regression caused by a recent update to core.
Feb 8, 2018
At some point, it'd be good to talk about what the monkey patch is for and add some kind of public API to take its place, but I'm cool with this if it fixes an immediate problem.