New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize command line paths with windows drive letters #16745

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Feb 15, 2018

Fixes #16740

In #16497, I generalized the behavior of atom --wait flag so that it will wait for a specific file path to close, rather than waiting for an entire window to close. Obviously, this new approach relies on file paths being represented consistently. In particular, if I open a file called C:/my/repo/.git/COMMIT_EDITMSG (forward slashes) the --wait session will not be terminated when I close a file called C:\my\repo\.git\COMMIT_EDITMSG (backslashes).

Previously, file paths passed as command line arguments were not normalized if they had the possibility of being URLs. This prevented windows paths with drive letters from being normalized. Now, we normalize any file path that exists on disk.

@maxbrunsfeld maxbrunsfeld merged commit 3078c4d into master Feb 15, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-normalize-windows-paths-for-wait-flag branch Feb 15, 2018

maxbrunsfeld added a commit that referenced this pull request Feb 15, 2018

Merge pull request #16745 from atom/mb-normalize-windows-paths-for-wa…
…it-flag

Normalize command line paths with windows drive letters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment