New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return value of sync confirm function #16748

merged 1 commit into from Feb 16, 2018


None yet
2 participants

UziTech commented Feb 15, 2018

Description of the Change

return the value of a callback function for the synchronous version of atom.confirm

Alternate Designs

Why Should This Be In Core?

this is returned for Atom v1.24


restores backwards compatibility

Possible Drawbacks


Verification Process

Applicable Issues

@Ben3eeE Ben3eeE requested a review from 50Wliu Feb 16, 2018


This comment has been minimized.


50Wliu commented Feb 16, 2018

Yep, there was an implicit Coffeescript return. /sigh

@50Wliu 50Wliu merged commit 82d5974 into atom:master Feb 16, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@50Wliu 50Wliu removed their request for review Feb 16, 2018

50Wliu added a commit that referenced this pull request Feb 16, 2018

Merge pull request #16748 from UziTech/patch-6
return value of sync confirm function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment