New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop scaling up small scroll wheel events #16753

Merged
merged 1 commit into from Feb 16, 2018

Conversation

Projects
None yet
3 participants
@billyjanitsch
Contributor

billyjanitsch commented Feb 15, 2018

Description of the Change

As discussed in #16743, this reverts #15487.

#15487 essentially compensated for the fact that wheelDelta was switched to delta in the 1.19 editor rewrite, reducing the scroll sensitivity by 1/3. Now that it's been switched back in 1.24, #15487 is no longer necessary, and in fact it stops the trackpad from distinguishing between different small velocities.

Per #16743, it would actually be best to move back to delta eventually, but only when the interaction with scroll sensitivity is properly figured out, such that #15487 isn't necessary either way.

cc @Ben3eeE @50Wliu @nathansobo

Benefits

This makes scrolling at low velocities feel slightly more natural on a macOS trackpad.

Possible Drawbacks

This should be safe because it only affects small scroll deltas which are only generated by trackpads.

Verification Process

Opened an editor window, pasted a large block of text, then scrolled around slowly using a macOS trackpad at different scroll sensitivities.

Applicable Issues

See #16743 and #15567.

@nathansobo nathansobo merged commit e334f04 into atom:master Feb 16, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nathansobo

This comment has been minimized.

Contributor

nathansobo commented Feb 16, 2018

I'm really hoping this doesn't have unintended consequences, but I think your thought process is reasonable.

@billyjanitsch billyjanitsch deleted the billyjanitsch:revert-15487 branch Feb 16, 2018

@50Wliu

This comment has been minimized.

Member

50Wliu commented Feb 18, 2018

@nathansobo do you think this should be hotfixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment