New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to write config file while quitting #16810

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Feb 21, 2018

Refs #16786
Refs #16628 (comment)

This is a bit speculative, but I think that this fixes a problem with the fix introduced in #16628. In that PR, I made all of the config file IO async. I'm concerned that what's happening is that some package is writing to atom.config on shutdown (which was the cause of the original bug) and the Atom main process is exiting after we start to write the config file but before the write completes.

To fix this case, I have added logic to prevent config file writes during shutdown.

/cc @rsese

@maxbrunsfeld maxbrunsfeld merged commit e638100 into master Feb 21, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-dont-write-config-when-quitting branch Feb 21, 2018

maxbrunsfeld added a commit that referenced this pull request Feb 21, 2018

Merge pull request #16810 from atom/mb-dont-write-config-when-quitting
Don't try to write config file while quitting

@maxbrunsfeld maxbrunsfeld restored the mb-dont-write-config-when-quitting branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment