Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Handle empty username #16823
Description of the Change
Changes Atom to use
If the username isn't necessarily required for the uniqueness of the hash, a simpler and probably slightly faster method would be to keep the current method of determining it and simply default to the empty string.
Why Should This Be In Core?
This is fixing a bug in core.
Atom doesn't crash when
This is likely to be slightly slower than the previous method of just checking environment variables.
I verified this was an issue using the steps outlined in #16821. To verify that this fixes the issue I set up an environment that the current version (v1.25.0-beta2) fails in, built a version based on this PR, and verified that the new build works properly in that environment.