New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test .oldPath and .path on rename events #16851

Merged
merged 4 commits into from Feb 28, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Feb 27, 2018

Report rename events that move files out from the PathWatcher's root as deletions and events that move files in as creations. This fixes a bug where rename events out of the watched root would be dropped (because .path was not within the normalized directory, even though .oldPath was) and ensures consistency across platforms with the way that "rename away" appears.

Fixes #16623.

smashwilson added some commits Feb 27, 2018

@smashwilson smashwilson merged commit 001aada into master Feb 28, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw-filter-event-paths branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment