Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Convert Dock class to Etch #16864
Since #16116 is going to require big changes to how docks are layed out (for which I'll be using etch), I wanted to convert Dock itself. Then I'll update
Dock was already written in a super Reacty way so there isn't much being changed here. Basically,
While working on this, I (re)discovered #16769. In order to be able to verify that I didn't make a mess of things with this PR, I fixed that issue in #16863 and rebased on that. I opened this as a PR against that branch for review purposes, but after that's merged I'll rebase it onto master and switch the base. Please let me know if there was a better way to do it!
referenced this pull request
Mar 12, 2018
Mar 30, 2018
1 check passed
Looks like this broke something. Both @lee-dohm and myself are unable to successfully launch Atom when building from source. Judging from the comments in the code related to snapshotting, I'm guessing something is failing there. Seeing errors like this (in safe mode) upon launching Atom:
@matthewwithanm Any ideas? Only workaround we've got so far is reverting to a commit before this got merged.
@matthewwithanm Let me know if you need anything else, but this is trivially reproducible merely by building from
My hunch is that this might somehow be related to snapshotting and/or ASAR packaging, since that is the only difference I can think of that sets CI builds apart from local development builds. Not sure if that makes sense though