New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native isArray, endsWith #16876

Merged
merged 1 commit into from Mar 3, 2018

Conversation

Projects
None yet
2 participants
@Connormiha
Contributor

Connormiha commented Mar 3, 2018

Description of the Change

  • Used native Array.isArray instead of Underscore's isArray.
  • Used native endsWith instead of Underscore's

Benefits

Less external dependencies

@50Wliu 50Wliu merged commit 6e6e44c into atom:master Mar 3, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment