New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize fontSize and lineHeight in the random test #16884

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
3 participants
@Ben3eeE
Member

Ben3eeE commented Mar 5, 2018

This causes the failure fixed by #15831 to be caught by the randomized test more easily.

Also removes the test merged with #15831 since it is not failing.

Verification Process

  • Revert the changes in #15831 and observe test failure with the seed 1520247533732
  • Restore the changes in #15831 and observe that this seed is passing.

/cc: @nathansobo

Randomize fontSize and lineHeight in the random test
This causes the failure fixed by #15831
to be caught by the randomized test more easily

@Ben3eeE Ben3eeE added the needs-review label Mar 5, 2018

@Ben3eeE Ben3eeE requested a review from as-cii Mar 5, 2018

@as-cii as-cii merged commit bfe37a4 into master Mar 6, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@as-cii as-cii deleted the b3-randomized-test branch Mar 6, 2018

@as-cii

This comment has been minimized.

Member

as-cii commented Mar 6, 2018

⚡️🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment