New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug caused by dragging file from desktop through dock handle #16936

Merged
merged 1 commit into from Mar 30, 2018

Conversation

Projects
None yet
2 participants
@matthewwithanm
Member

matthewwithanm commented Mar 12, 2018

This is a fix for #16933. To avoid rebase issues I based it on #16864.

The problem is that, while the workspace element only cares about drags originating from the current document, the same isn't true of the "dragenter" event that that dock uses. Rather than trying to handle this class of events specially in the dock, we simply limit our listening to when something is being dragged. Since we have a single source of truth for this information, this should be resilient to future changes in logic.

Don't trigger dock handle drag enter event unless a known item is bei…
…ng dragged

This seems a little counterintuitive. How could a dragenter event fire
if nothing's being dragged? Well, if something's dragged into the
document (i.e. from the desktop or another window), a dragenter event
will be fired even though (as far as we're concerned), nothing is being
dragged. Rather than trying to handle this class of events specially in
the dock, we simply limit our listening to when something is being
dragged. Since we have a single source of truth for this information,
this should be resilient to future changes in logic.
@daviwil

Awesome, thanks a lot for fixing this!

@daviwil daviwil merged commit a066295 into master Mar 30, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the fb-mdt-fix-16933 branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment