New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot creation after spell-check upgrade #16942

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@as-cii
Member

as-cii commented Mar 13, 2018

Description of the Change

This pull request pulls in the latest changes from electron-link which allow to exclude every module required from a particular file. With this new capability, we can now workaround the issue introduced with the upgrade of the spell-check package, which started requiring the xregexp module.

Specifically, we will now exclude all the modules required from node_modules/xregexp/xregexp-all.js; this file is already "browserified", meaning that it should be fine to embed it verbatim inside the snapshot. The errors observed in e.g. https://circleci.com/gh/atom/atom/7139 were in fact caused by trying to process xregexp's already "browserified" modules again using electron-link.

Alternate Designs

Unclear.

Benefits

The build will start passing again and we can use the latest version of spell-check as well.

Possible Drawbacks

Unclear.

Verification Process

  • CI is green again.
  • Verify that spell-check works correctly by typing non-English words in an untitled buffer.

/cc: @lee-dohm @daviwil

as-cii added some commits Mar 13, 2018

Exclude modules required from xregexp-all.js
This file is already "browserified", meaning that it should be fine to
embed it verbatim inside the snapshot. The errors observed in e.g.
https://circleci.com/gh/atom/atom/7139 were in fact caused by trying to
process xregexp's already "browserified" modules again using
electron-link.

@as-cii as-cii merged commit 3727c93 into master Mar 13, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@as-cii as-cii deleted the as-fix-snapshot-creation branch Mar 13, 2018

@daviwil

This comment has been minimized.

Member

daviwil commented Mar 13, 2018

👍 Thanks @as-cii!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment