Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Recognize .tsx source as Typescript #16944
Description of the Change
Although the (ancient) version of Typescript that we bundle doesn't understand
Alas, importing modules with a specified extension is explicitly disallowed by Typescript itself: see Microsoft/TypeScript#11901.
In general, it may be nice to allow custom transpilers to contribute recognized extensions to be added to
Why Should This Be In Core?
atom-ts-transpiler cannot import
TypeScript packages will be able to use
If any existing packages are using the built-in TypeScript transpiler and contain
I built a minimal TypeScript and React package and loaded it in dev mode with and without this change. Without it, the import statement for the
Mar 13, 2018
added a commit
this pull request
Mar 13, 2018
As a sidenote, for the non-immediate way forward, I'd love to see Atom get out of the business of transpiling altogether by making apm publish transpiled artifacts. That's even more engineering effort though, and I have no idea how soon we'd be able to start revisiting apm's design.
My logic is that any packages using the bundled TypeScript transpiler wouldn't have preexisting
Good point about documentation. I'll do a pass through the flight manual and
I'd be really curious to see how large of a population that set is
I know @maxbrunsfeld has a script to do operations on every published package... I've asked him what it is like three times, but I can never remember it
I checked sometime in December 2017, but I never got around to actually opening PRs, etc. If I remember correctly, less than 10 packages in total would possibly be affected by the upgrade. Verifying what, if anything broke, would require manual testing on a few packages due to missing or limited automated tests.
For the record, I completely agree with not upgrading bundled transpilers, but only if that means we are planning on removing all bundled transpilers. It's better to not ship anything, than to ship old, outdated bits (with known performance issues, and what not).