New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple config file paths #17040

Merged
merged 5 commits into from Mar 27, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Mar 27, 2018

When config file I/O was centralized to the main process, the Config object's mainSource is disregarded and all configs are serialized to the same file. This results in config file loss when using atom-mocha-test-runner because the AtomEnvironments built there enable persistence to a temporary directory:

global.buildAtomEnvironment = function (params = {}) {
  let defaultParams = {
    applicationDelegate,
    window,
    document,
    enablePersistence: true,
    configDirPath: tmpDir
  }
  return buildAtomEnvironment(Object.assign(defaultParams, params))
}

This restores the ability to track multiple Config objects and Atom environments by passing the source as well as the config payload to the main process through IPC.

Partial fix for #14909, specifically the bit where atom/github's test suite was resetting configuration 馃槈

smashwilson added some commits Mar 27, 2018

@smashwilson smashwilson referenced this pull request Mar 27, 2018

Closed

Settings lost #14909

0 of 1 task complete

@smashwilson smashwilson merged commit 5747cce into master Mar 27, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/config-loss branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment