Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Probot lock configuration #17041
Description of the Change
Add lock configuration in preparation for adding Lock Threads to the Atom organization.
Why Should This Be In Core?
It needs to be everywhere.
The triage team will have to deal less with people saying "me too" on closed issues that, while they may appear related, often aren't.
People may get upset that we're preventing them from commenting on old issues. Of course, they'll have to open new issues to let us know about it, which is the whole point.
Too many to list.
Our canned response is like
I like mentioning safe mode in the canned response in addition to it being a prerequisite in the issue template since it double confirms that safe mode has been checked.
Something like this is how I would write it if I combined the two and changed it up some
Would you mind updating the text for me? That looks…
On Tue, Mar 27, 2018 at 2:19 PM, Linus Eriksson ***@***.***> wrote: Our canned response is like if you can reproduce the issue after starting Atom in safe mode atom --safe then please open a new issue and completely fill out the provided issue template. I like mentioning safe mode in the canned response in addition to it being a prerequisite in the issue template since it double confirms that safe mode has been checked. Something like this is how I would write it if I combined the two and changed it up some
Sorry I didn't think of it. Can we link the Safe Mode suggestion to the Flight Manual?…
On Tue, Mar 27, 2018 at 2:26 PM, Linus Eriksson ***@***.***> wrote: @lee-dohm <https://github.com/lee-dohm> Sure thing. I updated it in 5ad7a0a <5ad7a0a> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17041 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_XKfNtxXcTUVykB4-EHbY3Av9kxDb1ks5tiq5ygaJpZM4S9nEO> .
@rsese Great question about
Options for these issues that I can see are:
So something like this for the 2nd option (Quick draft):
This doesn't really make sense as a message for something like merged PRs?
Atom should be capitalized in the safe mode link
Would it make sense to just submit a PR there adding the ability to filter out specific labels?
This is currently only applying to issues.
Yeah, it would be better to have a different comment for PRs, I'll copy the way Stale handles configuration in the near future and update you here, for now please limit the bot to issues only.
Mar 29, 2018
Just noticed the number of inactive issues you have: https://github.com/atom/atom/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aclosed+updated%3A%3C2017-09-30
This will mean 30 emails every hour in the next two weeks for repo watchers, 10k in total. Then there are the issue subscribers.
Alternatively you can opt to lock issues which have been inactive for more than a year without posting a comment, then switch back to the current config two weeks from now. That way repo watchers would get 1.3k emails instead of 10k.
I agree that locking without mentioning any reason could be confusing for those who stumble upon these threads, even if you decide to do so for very old issues only. I'm just not sure how will people react to their inboxes.
Setting custom config options for pull requests is now possible: https://github.com/dessant/lock-threads#configuration.
Though pull requests stop being processed after a while regardless of the config values due to a search API issue.