New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate command bindings for undo and redo #17050

Merged
merged 1 commit into from Mar 30, 2018

Conversation

Projects
None yet
2 participants
@maxbrunsfeld
Contributor

maxbrunsfeld commented Mar 29, 2018

This fixes a regression introduced in #16999. The core:undo and core:redo commands were registered twice: once for non-read-only editors and once for all editors. This caused the undo and redo methods to get called twice when typing command-z and command-shift-z (or when dispatching core:undo/core:redo from the command palette).

@maxbrunsfeld maxbrunsfeld requested a review from smashwilson Mar 29, 2018

@smashwilson

D'oh! Nice catch.

Remove duplicate command bindings for undo and redo
Co-authored-by: Nathan Sobo <nathan@github.com>

@maxbrunsfeld maxbrunsfeld merged commit d8d0009 into master Mar 30, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-fix-duplicate-command-bindings branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment