Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
:arrow_up: email@example.com #17088
Description of the change
Atom 1.25 and 1.26 ships with firstname.lastname@example.org. This is an older version that has not been upgraded since the tests were not passing. This failing test has been fixed in email@example.com. After this was merged tree-view was bumped to 0.222.0 instead of 0.223.0. This seemed like a mistake and that the intent was to upgrade to firstname.lastname@example.org. I asked about this and @50Wliu confirmed that it seems like we should be on email@example.com. I tried upgrading tree-view directly on the master branch but there seems to be a failing test on circleci after upgrading.
Comparing the current shipped version and the latest version:
Comparing the current version on atom/atom master branch with the latest version:
referenced this pull request
Apr 13, 2018
changed the title from
Aug 10, 2018
Ok, made some progress on this. The failures are due to atom/tree-view#1048. When the tree-view tests are run as part of Atom's CI, the project folder is set to
I think I need to adjust the failing test to use a temp directory as its project folder so that paths will not be considered as ignored.
added a commit
this pull request
Aug 20, 2018
The latest failure is a keybinding-resolver failure which looks like a flake.