New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white I-beam cursor #17208

Merged
merged 2 commits into from Apr 24, 2018

Conversation

Projects
None yet
1 participant
@simurai
Member

simurai commented Apr 24, 2018

Description of the Change

Fixes the white I-beam cursor in dark themes on macOS.

Why Should This Be In Core?

It's part of the /static styles.

Benefits

The white I-beam cursor is easier to see on a dark background.

Possible Drawbacks

None

Verification Process

  1. Open Atom on macOS.
  2. Switch to a dark theme.
  3. Open a file.
  4. Confirm that the I-beam cursor is white when over an editor.

Applicable Issues

Fixes #17174

@simurai simurai referenced this pull request Apr 24, 2018

Closed

White-cursor gone in 1.26.0 #17174

1 of 1 task complete

@simurai simurai merged commit 93690a6 into master Apr 24, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-ibeam branch Apr 24, 2018

maxbrunsfeld added a commit that referenced this pull request Apr 25, 2018

Merge pull request #17208 from atom/sm-ibeam
Fix white I-beam cursor

maxbrunsfeld added a commit that referenced this pull request Apr 25, 2018

Merge pull request #17208 from atom/sm-ibeam
Fix white I-beam cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment