New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait to initialize auto update manager until config is loaded #17216

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Apr 25, 2018

Fixes #17172

This regressed in #16628.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Apr 25, 2018

FWIW, Here was my testing strategy:

  1. Disable the Automatically Update setting.
  2. Add the following line to the beginning of AutoUpdateManager.scheduleUpdateCheck:
console.log('scheduleUpdateCheck')
  1. Run atom --dev --foreground.
  2. See the scheduleUpdateCheck message appear. This confirms the bug; that method should not be getting called.

After this change, the message no longer appears.

@maxbrunsfeld maxbrunsfeld merged commit d07e0d6 into master Apr 25, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-respect-auto-update-setting branch Apr 25, 2018

maxbrunsfeld added a commit that referenced this pull request Apr 25, 2018

Merge pull request #17216 from atom/mb-respect-auto-update-setting
Wait to initialize auto update manager until config is loaded

maxbrunsfeld added a commit that referenced this pull request Apr 25, 2018

Merge pull request #17216 from atom/mb-respect-auto-update-setting
Wait to initialize auto update manager until config is loaded

maxbrunsfeld added a commit that referenced this pull request May 1, 2018

Move auto update initialization back to AtomApplication.initialize
This fixes some CI problems introduced in #17216

maxbrunsfeld added a commit that referenced this pull request May 1, 2018

Move auto update initialization back to AtomApplication.initialize
This fixes some CI problems introduced in #17216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment