New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ electron@1.7.14 #17254

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
1 participant
@jasonrudolph
Member

jasonrudolph commented May 1, 2018

Upgrade from Electron 1.7.11 to 1.7.14 (i.e., the latest version in the Electron 1.7.x series).

Release notes:

@jasonrudolph

This comment has been minimized.

Member

jasonrudolph commented May 1, 2018

@Ben3eeE was kind enough to look over the Electron release notes to try to identify any manual testing that we should perform as part of this upgrade. He pointed out that this item from the Electron 1.7.13 release is worth testing:

Fixed support for precision trackpad / mouse scrolling.

He pointed me toward the test plan in #16114. With that in mind, I built this branch for 32-bit Windows and ran through the following test plan:

  • Scrolling on Windows with a mouse
    • Scroll in every direction
    • Scroll in every direction while holding shift
  • Scrolling on Windows with a touchpad
    • Scroll in every direction
    • Scroll in every direction while holding shift
    • Slightly scroll down/up, ensuring that for small values of wheelDeltaY * scrollSensitivity we still honor the scrolling
    • Slightly scroll left/right, ensuring that for small values of wheelDeltaX * scrollSensitivity we still honor the scrolling

Everything seems to be working as expected. 😅

Thanks for the help, @Ben3eeE! ⚡️

@jasonrudolph jasonrudolph merged commit ac43bca into master May 1, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the electron-1.7.14 branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment