New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated hidden-inset title bar style #17373

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
4 participants
@npezza93
Contributor

npezza93 commented May 20, 2018

As of electron/electron#11975 the hidden-inset
titleBarStyle has been removed so the custom-inset title bar option
renders a normal title bar which is not desired.

Fix deprecated hidden-inset title bar style
As of electron/electron#11975 the hidden-inset
titleBarStyle has been removed so the custom-inset title bar option
renders a normal title bar which is not desired.

@Ben3eeE Ben3eeE requested a review from jasonrudolph May 21, 2018

@Arcanemagus

This comment has been minimized.

Contributor

Arcanemagus commented May 21, 2018

This looks like it might be the cause of #17377?

@npezza93

This comment has been minimized.

Contributor

npezza93 commented May 21, 2018

@Arcanemagus Yea that's correct

@jasonrudolph

This comment has been minimized.

Member

jasonrudolph commented May 24, 2018

I checked out this branch locally and ran through the following verification process:

Verification Process

For each supported title bar setting, verify that the title bar behavior on this branch matches the title bar behavior in Atom 1.27.1

  • native
  • custom
  • custom-inset
  • hidden

@jasonrudolph jasonrudolph merged commit 420bae0 into atom:1.28-releases May 24, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@npezza93 npezza93 deleted the npezza93:fix-hidden-inset branch May 24, 2018

@bittin bittin referenced this pull request Jul 25, 2018

Closed

1.28 releases #17733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment