Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid masking exceptions as cancellations in Workspace.open #17424
Previously, when opening a file via
This PR simplifies that
I believe this problem was introduced in #16229. It's generally not a big deal, because in most cases, the methods I mentioned above won't throw exceptions. @nathansobo noticed this bug when attempting to use an incompatible version of tree-sitter-rust. An exception is thrown when trying to use a parser whose ABI is incompatible with the current version of Tree-sitter.