New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom/watcher upgrade #17432

Merged
merged 4 commits into from Jul 30, 2018

Conversation

Projects
None yet
3 participants
@smashwilson
Member

smashwilson commented May 30, 2018

Upgrading @atom/watcher to 1.0.8 appears to consistently break the npm we bundle within apm:

npm ERR! enoent ENOENT: no such file or directory, rename '/Users/distiller/atom/node_modules/.staging/abbrev-6970c326' -> '/Users/distiller/atom/node_modules/@atom/watcher/node_modules/abbrev'
npm ERR! enoent ENOENT: no such file or directory, rename '/Users/distiller/atom/node_modules/.staging/abbrev-6970c326' -> '/Users/distiller/atom/node_modules/@atom/watcher/node_modules/abbrev'

I suspect the solution may be "upgrade npm in apm".

@fosslinux

This comment has been minimized.

Show comment
Hide comment
@fosslinux

fosslinux Jun 13, 2018

Doesn't fix... same error.

fosslinux commented Jun 13, 2018

Doesn't fix... same error.

@smashwilson

This comment has been minimized.

Show comment
Hide comment
@smashwilson

smashwilson Jul 30, 2018

Member

Grrr.

Node:	v8.9.3
Npm:	v5.3.0
Installing script dependencies
Installing apm
npm ERR! path /Users/distiller/atom/apm/node_modules/atom-package-manager/node_modules/npm/node_modules/abbrev
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/Users/distiller/atom/apm/node_modules/atom-package-manager/node_modules/npm/node_modules/abbrev' -> '/Users/distiller/atom/apm/node_modules/atom-package-manager/node_modules/npm/node_modules/.abbrev.DELETE'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/distiller/.npm/_logs/2018-07-30T13_28_20_673Z-debug.log
child_process.js:624
    throw err;
    ^

Error: Command failed: /Users/distiller/atom/script/node_modules/.bin/npm --global-style --loglevel=error install

I'm guessing we also need to update the version of npm we're installing in script/. 🤔

Member

smashwilson commented Jul 30, 2018

Grrr.

Node:	v8.9.3
Npm:	v5.3.0
Installing script dependencies
Installing apm
npm ERR! path /Users/distiller/atom/apm/node_modules/atom-package-manager/node_modules/npm/node_modules/abbrev
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/Users/distiller/atom/apm/node_modules/atom-package-manager/node_modules/npm/node_modules/abbrev' -> '/Users/distiller/atom/apm/node_modules/atom-package-manager/node_modules/npm/node_modules/.abbrev.DELETE'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/distiller/.npm/_logs/2018-07-30T13_28_20_673Z-debug.log
child_process.js:624
    throw err;
    ^

Error: Command failed: /Users/distiller/atom/script/node_modules/.bin/npm --global-style --loglevel=error install

I'm guessing we also need to update the version of npm we're installing in script/. 🤔

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Jul 30, 2018

Member

Weird, I never noticed that we're installing a specific npm version in there. Can we get rid of that now since I think we only did it to fix issues on AppVeyor?

#15041

Member

daviwil commented Jul 30, 2018

Weird, I never noticed that we're installing a specific npm version in there. Can we get rid of that now since I think we only did it to fix issues on AppVeyor?

#15041

smashwilson added some commits Jul 30, 2018

@smashwilson

This comment has been minimized.

Show comment
Hide comment
@smashwilson

smashwilson Jul 30, 2018

Member

It looks like that npm installation is used to install apm and (somehow?) other script/ dependencies?

Let's at least bump it and see if that solves the bootstrapping problem... if not, I can investigate getting rid of it and using system npm for simplicity.

Member

smashwilson commented Jul 30, 2018

It looks like that npm installation is used to install apm and (somehow?) other script/ dependencies?

Let's at least bump it and see if that solves the bootstrapping problem... if not, I can investigate getting rid of it and using system npm for simplicity.

@smashwilson smashwilson merged commit 1b3f99c into master Jul 30, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/watcher-up branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment