Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Extend the color profile PR (#17380) #17464
Description of the Change
Extends #17380 by wiring up the dialog prompt for restarting Atom whenever the
The third (and optional) change alters the bound functions used when wiring up the change event listeners to arrow functions. We can drop that commit if it's deemed risky, not necessary, or some such.
A more elaborate opt-in mechanism for "prompt for relaunch" was considered, but rejected after taking into consideration the concept of YAGNI™.
Why Should This Be In Core?
For obvious reasons.
Users do not have to manually restart Atom. Some users will likely not read the description and realize they need to manually restart Atom, which would most likely lead to issues being submitted, etc.
More code, and complexity?
Manually tested on Ubuntu 16.04. Works as expected.
This change is simple enough that I don't see any problem merging this PR right after I merge the color profile PR. I think I'd prefer leaving the "restart" language in the setting description though, just for the sake of clarity.
Thanks again for putting this together!