New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up: electron-link #17479

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Jun 6, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This change bumps electron-link to v0.2.2, enabling Atom builds on Node.js 10. See this issue for more details: atom/electron-link#11

Alternate Designs

No alternative designs needed.

Why Should This Be In Core?

This is part of Atom's build script.

Benefits

Users can now build Atom using Node.js 10.

Possible Drawbacks

Newer version of leveldown in electron-link could cause issues, but it's a necessary change.

Verification Process

Clean CI on electron-link, also checking for clean CI on Atom.

Applicable Issues

atom/electron-link#11

@daviwil daviwil merged commit d745ea7 into master Jun 6, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-update-electron-link branch Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment