New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist `yauzl` from snapshot #17481

Merged
merged 3 commits into from Jun 6, 2018

Conversation

Projects
None yet
2 participants
@thomasjo
Member

thomasjo commented Jun 6, 2018

Description of the Change

This PR adds yauzl to the snapshot blacklist in order to leverage recent changes to ls-archive in which we switched from a dependency on decompress-zip to yauzl.

Why Should This Be In Core?

Because snapshotting happens in core, and we bundle the archive-view package that pulls in the problematic yauzl npm package.

Benefits

Allows us to keep modernizing archive-view, and also resolves the intermittent problem with the outdated string_decoder package used by decompress-zip's dependency chain.

Possible Drawbacks

None?

Verification Process

Tested locally (on macOS 10.13.5) by running script/build --install.

Applicable Issues

Fixes #17125 (for real this time).

@thomasjo thomasjo merged commit 9e0065c into master Jun 6, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thomasjo thomasjo deleted the blacklist-yauzl-from-snapshot branch Jun 6, 2018

@lierdakil lierdakil referenced this pull request Jun 7, 2018

Closed

Failed to build Atom v1.27.2 #17484

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment