New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Desktop SCL compat by setting exec path #17508

Merged
merged 2 commits into from Sep 6, 2018

Conversation

Projects
None yet
5 participants
@rayfoss
Contributor

rayfoss commented Jun 13, 2018

Description of the Change

Based on this zombie PR:
#15887

Meant to address #13451 which produces about 4 SCL warnings on plugins that use terminal utilities on RHEL based distributions. Including the official github package.

Why Should This Be In Core?

It's a frustrating bug to anyone who uses any terminal, git and other Atom plugins in Fedora.

Benefits

Clean running Atom plugins on RHEL

Possible Drawbacks

None.

Verification Process

Started Atom with the change and the SCL warnings were gone.

Testing procedure:

  1. open a project with git in atom
  2. set the origin url to a bad origin
  3. git remote set-url origin git@gitlab.com:tdps/non-existant-repo
  4. Behold the strange output

Pre patch:
screen shot 2018-06-13 at 9 24 32 am

Post patch:
screen shot 2018-06-13 at 9 28 11 am

Applicable Issues

#13451
platformio/platformio-atom-ide-terminal#120 (comment)

.Desktop SCL compat by setting exec path
based on this zombie PR:
#15887
@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jun 13, 2018

Thank you for submitting this @rayfoss

ashcrow commented Jun 13, 2018

Thank you for submitting this @rayfoss

@daviwil daviwil referenced this pull request Jun 13, 2018

Closed

Strange output #13451

6 of 6 tasks complete
@TJProgrammer

This comment has been minimized.

Show comment
Hide comment
@TJProgrammer

TJProgrammer Jun 13, 2018

Thanks @rayfoss for this PR!

TJProgrammer commented Jun 13, 2018

Thanks @rayfoss for this PR!

@daviwil

daviwil approved these changes Sep 6, 2018

Sorry for the delay! This change looks great and the VSTS failure is unrelated to what you've done here. Merging this, thanks @rayfoss!

@daviwil daviwil merged commit 50bf905 into atom:master Sep 6, 2018

2 of 3 checks passed

Atom Pull Requests #20180906.2 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment