Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "File -> Open" to work on macOS when no windows are open #17529

Merged
merged 3 commits into from Feb 7, 2019

Conversation

Projects
None yet
7 participants
@karevn
Copy link
Contributor

karevn commented Jun 17, 2018

Currently, Atom only sets up "File -> Open" menu handler upon window creation. That means, that when there are no windows opened on macOS - File -> Open does nothing. I've added event handlers which don't depend on window creation to make it work all the time.

@lee-dohm

This comment has been minimized.

Copy link
Member

lee-dohm commented Jul 17, 2018

@daviwil Can you take a look here?

@jrtibbetts

This comment has been minimized.

Copy link

jrtibbetts commented Aug 8, 2018

It sounds like this should fix #17727, which would be enormously helpful to me.

@jrtibbetts

This comment has been minimized.

Copy link

jrtibbetts commented Aug 20, 2018

Who can merge this?

@karevn

This comment was marked as spam.

Copy link
Contributor Author

karevn commented Sep 27, 2018

Guys, it's getting strange to spend 3 months reviewing such a small PR.

@makingoff

This comment has been minimized.

Copy link

makingoff commented Nov 1, 2018

@daviwil could you take a look?

@lee-dohm

This comment has been minimized.

Copy link
Member

lee-dohm commented Nov 1, 2018

@makingoff @daviwil is on parental leave for the time being. We've got this in the queue for prioritization.

@karevn

This comment was marked as off-topic.

Copy link
Contributor Author

karevn commented Nov 6, 2018

chop-chop, that's a sound of people footsteps going to VSCode.

@lee-dohm

This comment has been minimized.

Copy link
Member

lee-dohm commented Nov 19, 2018

Would you mind adding some tests for this?

@karevn

This comment was marked as off-topic.

Copy link
Contributor Author

karevn commented Nov 19, 2018

I gave up using Atom.

@daviwil daviwil force-pushed the karevn:issue-17528 branch from b051e41 to 4498b9a Feb 7, 2019

@daviwil daviwil force-pushed the karevn:issue-17528 branch from 4498b9a to 37ae5dd Feb 7, 2019

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Feb 7, 2019

I verified this fix locally and also added a test that ensures the behavior going forward. Thanks a lot for the contribution @karevn!

@daviwil daviwil merged commit bded0c1 into atom:master Feb 7, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Atom Pull Requests #20190207.9 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil changed the title File -> Open works without open windows Enable "File -> Open" to work on macOS when no windows are open Feb 7, 2019

daviwil added a commit that referenced this pull request Feb 7, 2019

Merge pull request #17529 from karevn/issue-17528
File -> Open works without open windows

@daviwil daviwil referenced this pull request Feb 15, 2019

Merged

Fix "Open Folder" menu item on Windows #18855

2 of 2 tasks complete

@rsese rsese referenced this pull request Mar 5, 2019

Closed

File > Open… doesn't work when there are no open windows #18941

1 of 1 task complete

@bloopletech bloopletech referenced this pull request Mar 12, 2019

Closed

File -> Open Folder displays Open File dialog #18971

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.