Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jasmine stacktrace formatting #17609

Merged
merged 1 commit into from Jul 1, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

50Wliu commented Jul 1, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Updating Electron to 2.x changed how stacktraces are reported, so the logic needed to be updated.

Alternate Designs

I'm not sure if the two other ones are needed anymore.

Why Should This Be In Core?

Stacktrace formatting is handled by core.

Benefits

Cleaner stacktraces when using the GUI test runner.

Possible Drawbacks

None.

Verification Process

Ran a failing test with and without this change and noted the reported stacktrace.

Applicable Issues

None.

@50Wliu 50Wliu merged commit f99077c into master Jul 1, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-jasmine-format branch Jul 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.