Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete the package-lock.json in /script/vsts #17677

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
2 participants
@lee-dohm
Copy link
Member

lee-dohm commented Jul 12, 2018

Description of the Change

In #16493, I added a step to the build script to delete package-lock.json files from the tree because they were causing problems with building under certain versions of Node. I noticed that in the new nightly releases the package-lock.json is checked in and is apparently being used by the build. This change ignores that specific lockfile in order to keep everything tidy when building.

Alternate Designs

Considered taking this out and dealing with having the lockfiles but I'm still not sure we're ready for that.

Why Should This Be In Core?

This is a change to core.

Benefits

You don't have to revert the deletion of the lockfile every time you build.

Possible Drawbacks

🤷‍♂️

Verification Process

Built using this change and script/vsts/package-lock.json was still there but the others weren't.


/cc @daviwil to double-check that having script/vsts/package-lock.json checked in is intentional.

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jul 12, 2018

Interesting, I hadn't actually seen the file get deleted but that's probably because I've been building this on CI every time instead of my local machine :) Thanks a lot Lee!

@daviwil daviwil merged commit 8fadbae into master Jul 12, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the leave-vsts-locked branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.