Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node 8.9.3 in Atom CI builds #17679

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Copy link
Member

daviwil commented Jul 12, 2018

Description of the Change

Since we're now using Electron 2.0 which uses Node 8.9.3, it makes sense to use that same version in our CI build so that our build scripts have access to the same goodies as Atom itself. This should also speed up our builds somewhat since there were some performance improvements

Specific installations of npm 5.3.0 have been removed since npm 5.5.0 comes with Node 8.9.3.

Alternate Designs

Rewrite Atom build scripts in Python

Why Should This Be In Core?

It's CI, dudes

Benefits

Even Noder than before

Possible Drawbacks

8 looks like eyes if you turn your head sideways

Verification Process

Wait for CI to go green

Applicable Issues

None

@daviwil daviwil merged commit 32a6aca into master Jul 12, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-use-node-8-in-ci branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.