Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Modify TextEditorComponent updateClassList to always add managed classes to element #17702
Description of the Change
Why Should This Be In Core?
This address an issue that exists in one of the main core classes, which is used within other atom/atom classes. Implementing the change in a separate package would add an unnecessary additional dependency
This change will allow external packages to dynamically set element classes without having to worry about losing the managed classes (editor, mini, is-focused). This is especially useful in React components that reuse an element when re-rendering
This change will affect packages' styling of atom-text-editor elements which rely on the managed classes not being re-applied. In such cases, the packages can regain specificity by adding the appropriate managed class names to the selectors.