Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub package on Beta #17704

Merged
merged 2 commits into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@smashwilson
Copy link
Member

smashwilson commented Jul 17, 2018

Bring the improvements from dev over to the beta hotfix branch to ensure they're included in the next stable release.

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jul 17, 2018

Good idea! Should we wait to merge this until just after we roll the railcars, probably late next week? Never know if we'll end up needing to do another hotfix for Electron 2.0 stuff

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Jul 17, 2018

I can double-check what the changelog is for v0.17.0..v0.17.2, but generally we only merge bugfixes on older release branches, so this should be fairly safe.

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jul 17, 2018

Ahhh, I was assuming this was bumping to 0.18.0, should have read the friggin diff ;)

@smashwilson smashwilson merged commit 7107b01 into 1.29-releases Jul 17, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/github-up-beta branch Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.