Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs found when adding ruby tree-sitter grammar #17717

Merged
merged 7 commits into from Jul 20, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Jul 19, 2018

This PR upgrades language-ruby to include atom/language-ruby#225, and upgrades language-html to include an ERB grammar. The ruby parser surfaced a couple of bugs in the way the TreeSitterLanguageMode uses the syntax trees. I've fixed them here.

@maxbrunsfeld maxbrunsfeld force-pushed the mb-tree-sitter-fixes branch from fac30f4 to 137acb2 Jul 20, 2018

@maxbrunsfeld

This comment has been minimized.

Copy link
Contributor Author

maxbrunsfeld commented Jul 20, 2018

@314eter This PR fixes a logic error related to updating the cache of foldable rows, so I think it will address that part of #17596.

@maxbrunsfeld maxbrunsfeld merged commit 6740222 into master Jul 20, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-tree-sitter-fixes branch Jul 20, 2018

@314eter 314eter referenced this pull request Jul 22, 2018

Open

Tree-sitter folding #17596

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.