Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce `observeRepositories` and `onDidAddRepository` #17720

Merged
merged 3 commits into from Jul 20, 2018

Conversation

Projects
None yet
3 participants
@jasonrudolph
Copy link
Member

jasonrudolph commented Jul 20, 2018

In support of atom/metrics#98, this pull request adds two new public APIs:

  • atom.project.observeRepository(callback): Invokes the given callback with all current repositories in atom.project and all future repositories added to atom.project
  • atom.project.onDidAddRepository(callback): Invokes the given callback each time a repository is added to atom.project

jasonrudolph added some commits Jul 20, 2018

@jasonrudolph jasonrudolph requested a review from maxbrunsfeld Jul 20, 2018

@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld left a comment

Looks 💯

@daviwil
Copy link
Member

daviwil left a comment

Lookin' good!

Fix overly-specific assertion
Fixes failing assertions [1] that unnecessarily assumed that the 
repository was cloned using `https://github.com/atom/atom.git` as the 
URL, as opposed to `git@github.com:atom/atom.git` as the URL.

[1] https://circleci.com/gh/atom/atom/7981

@jasonrudolph jasonrudolph merged commit 457cde4 into master Jul 20, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the jr-observe-repositories branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.