Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix failing Windows nightly builds #17723
Description of the Change
Windows builds for Atom Nightly releases started failing two days ago with this error:
The problem here is that when generating a delta package, Squirrel is looking for the previous version of
The solution for now is to turn off delta package builds only for Nightly releases until we can get the underlying issue fixed in Squirrel.Windows and Squirrel's fork of NuGet 2.0.
The ideal fix is to change how version comparisons work in Squirrel's fork of NuGet 2.0. The offending code is here:
This comparison should be changed to use the
We won't have delta packages for now, meaning that users will have to download the full nuget package for each Nightly release on Windows until this bug is fixed. This isn't a huge concern since macOS users already have to do this as Squirrel.Mac doesn't support delta packages.