Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository tests that fail when run in fork of atom/atom #17752

Merged
merged 1 commit into from Jul 27, 2018

Conversation

Projects
None yet
2 participants
@jasonrudolph
Copy link
Member

jasonrudolph commented Jul 27, 2018

Prior to this change, two of the repository-related tests assumed that they were running in a local checkout of https://github.com/atom/atom, and the tests unintentionally failed if the local repository was a fork of atom/atom.

We first noticed this failure in https://circleci.com/gh/marcomorain/atom-1/29:

Project
  .onDidAddRepository()
    it invokes callback when a path is added and the path is the root of a repository
      Expected 'git@github.com:marcomorain/atom-1.git' to contain 'atom/atom'.
        at jasmine.Spec.it (/Users/distiller/project/spec/project-spec.js:1006:42)
    it invokes callback when a path is added and the path is subdirectory of a repository
      Expected 'git@github.com:marcomorain/atom-1.git' to contain 'atom/atom'.
        at jasmine.Spec.it (/Users/distiller/project/spec/project-spec.js:1017:42)

Instead of depending on the local checkout of the atom repository for these tests, this pull request updates the tests to use one of the fixture repositories. 馃槄

Fix repository tests that fail when run in fork of atom/atom
Prior to this change, these tests assumed that the local repository is a
clone of atom/atom, and the tests (unintentionally) failed if the local
repository was a fork of atom/atom:

https://circleci.com/gh/marcomorain/atom-1/29

Instead of depending on the local clone of the atom repository for these
tests, this commit updates the tests to use one of the fixture
repositories. 馃槄

@jasonrudolph jasonrudolph self-assigned this Jul 27, 2018

@jasonrudolph jasonrudolph requested a review from maxbrunsfeld Jul 27, 2018

@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld left a comment

鈿★笍 Great solution!

@jasonrudolph jasonrudolph merged commit 24fe715 into master Jul 27, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the jr/fix-failing-repo-tests branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.