New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing x64 build artifacts to appveyor.yml #17761

Merged
merged 1 commit into from Jul 30, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Jul 30, 2018

This change fixes an issue introduced by PR #17538 which changed how we name build artifacts on Windows. Previously, our build scripts named AtomSetup.exe, atom-windows.zip, and RELEASES the same for x64 and x86 builds. The aforementioned PR changed the build scripts to add x64 into these filenames on x64 builds to match what we deliver as release assets.

This change updates appveyor.yml to ensure that the x64 artifacts are uploaded on successful AppVeyor builds.

/cc @jasonrudolph

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Jul 30, 2018

Member

Since artifacts aren't generated on PR builds, we've verified that this fix works on a test release branch: https://ci.appveyor.com/project/Atom/atom/build/10760

Member

daviwil commented Jul 30, 2018

Since artifacts aren't generated on PR builds, we've verified that this fix works on a test release branch: https://ci.appveyor.com/project/Atom/atom/build/10760

@daviwil daviwil merged commit 9654502 into master Jul 30, 2018

0 of 3 checks passed

ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@daviwil daviwil deleted the dw-fix-appveyor-x64-windows branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment