Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Write config file atomically #17774
Description of the Change
We (the Nuclide team) continue to have reports of #17060 from Windows users, even after #17166. The cause isn't certain, however, we do know that the
I rolled back the fix from #17060 to get back to a state where the issue could be reproduced somewhat reliably, then made the change an was unable to repro. This isn't a guaranteed fix (since the same could be said about #17060), but it seems more robust.
I was initially worried about the watcher not picking up the replace, but I tested that file updates were reflected in UI and that UI updates were mirrored to the file on both MacOS and Windows and we're good.
I was unable to get the config to reset on a build based on 841b01a, so at worst from what I can tell it is the same as what we currently have published.
A few things of interesting note:
I have noticed a potential downside of this PR: The